ryantam626 opened a new pull request, #25055:
URL: https://github.com/apache/airflow/pull/25055

   According to k8s's docs on pod phase [1], "Running" state means "The Pod has 
been bound to a node,
   and all of the containers have been created. At least one container is still 
running,
   or is in the process of starting or restarting.".
   
   There is no guarantee that the xcom sidecar container will have been
   running by the time the `extract_com` is used by KPO's `execute` -
   meaning if the base container has completed before the xcom sidecar
   container is running, the entire operator fails because you cannot exec
   against a non-running container.
   
   Fix is to wait for the xcom sidecar container to be in the running state
   before we exec against it, which this commit implements.
   
   [1] - 
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-phase
   [2] - 
https://github.com/schattian/airflow/blob/86171ff43f8977021708cfa241da64f96c4c15e2/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L398
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to