uranusjr commented on code in PR #25045:
URL: https://github.com/apache/airflow/pull/25045#discussion_r921758228
##########
airflow/models/dag.py:
##########
@@ -2498,12 +2498,8 @@ def bulk_write_to_db(cls, dags: Collection["DAG"],
session=NEW_SESSION):
orm_dag.max_active_tasks = dag.max_active_tasks
orm_dag.max_active_runs = dag.max_active_runs
orm_dag.has_task_concurrency_limits = any(t.max_active_tis_per_dag
is not None for t in dag.tasks)
- if dag.schedule_on:
- orm_dag.schedule_interval = 'Dataset'
- orm_dag.timetable_description = 'Triggered by datasets.'
- else:
- orm_dag.schedule_interval = dag.schedule_interval
- orm_dag.timetable_description = dag.timetable.description
+ orm_dag.schedule_interval = dag.schedule_interval
Review Comment:
Yes the key “problem” per-se is that `DAG.schedule_interval` at this point
does not actually have any functionality beyond determining the label name we
show on the UI. A rename here is really needed to reflect that, and this change
makes sense if you look pass the attribute name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
