dstandish commented on code in PR #25086:
URL: https://github.com/apache/airflow/pull/25086#discussion_r922269083
##########
airflow/models/taskinstance.py:
##########
@@ -1518,7 +1518,8 @@ def _run_raw_task(
if not test_mode:
session.add(Log(self.state, self))
session.merge(self)
- self._create_dataset_dag_run_queue_records(session=session)
+ if self.state != State.SKIPPED:
Review Comment:
> Wait, should we test if it's in State.SUCCESS instead?
i think the only way you get here is if you are success or skipped but yeah
probably best to just check for success 👍
when i first did this i thought you could only get here if _successful_ but
missed the skipped part (and i hadn't noticed the line in the AIP that
describes skip behavior)
##########
airflow/models/taskinstance.py:
##########
@@ -1518,7 +1518,8 @@ def _run_raw_task(
if not test_mode:
session.add(Log(self.state, self))
session.merge(self)
- self._create_dataset_dag_run_queue_records(session=session)
+ if self.state != State.SKIPPED:
Review Comment:
> Wait, should we test if it's in State.SUCCESS instead?
i think the only way you get here is if you are success or skipped but yeah
probably best to just check for success 👍
when i first did this i thought you could only get here if _successful_ but
missed the skipped part (and i hadn't noticed the line in the AIP that
describes skip behavior anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
