potiuk commented on PR #639:
URL: https://github.com/apache/airflow-site/pull/639#issuecomment-1186992309

   > Won't this make it possible for someone to push a commit directly to main 
without making a pull request? If it will, I would suggest still protecting 
main because I have occasionally iterated changes on a repo main and tried 
pushing only to realize that I'm on main. Some other persons may also be facing 
this issue
   
   Yep. you are absolutely right.
   
   I changed it now, to still require a PR and status checks to pass, but no 
longer require an approval.
   
   This is - I think - the best approach. We won't be able to force-push to 
master, we will always have to go through PR which will have to pass all the 
checks (I.e. the site shoudl build), and the PR will have to be based on latest 
`main` - keeping linear history and forcing the contributor to rebase before 
merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to