potiuk commented on PR #25121: URL: https://github.com/apache/airflow/pull/25121#issuecomment-1187567604
Hey @BasPH, @eladkal I took your comments in and rephrased it a bit. I removed "worker" and "k8s" references and replaced it with more generic "task execution". I also added a few improvements to make the description and tests more "robust": * I made sure to reflect some of the recent changes (it's either "scheduler" or "dag-processor") * I added an extra check to detect if second argument is "tasks". The problem is that in more general case both scheduler and dag processor can be executed with extra args that might make the "scheduler" or "dag-processor" command to have more than 3 args. Checking for > 3 and whether second arg is "tasks" is much more robust. Also it has the nice side effect that this optimisation will also work for "airflow tasks test" command - which I think users of such dynamic dags would badly, badly need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
