potiuk commented on code in PR #25100:
URL: https://github.com/apache/airflow/pull/25100#discussion_r923508144
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -288,6 +288,7 @@ operators:
- integration-name: AWS Lambda
python-modules:
- airflow.providers.amazon.aws.operators.aws_lambda
Review Comment:
Hmm. I think we should fix the failing tests actually. I prefer to keep the
provider.yaml to describe "current" state not some mixture between new and old
state - we do not track which entries are deprecated here.
BTW. Maybe there are other cases like that already but if they are, we
should fix it so that the tests do not fail here and right after we should add
tests finding similar deprecated entries and remove them. Happy to do it as a
follow-up actually.
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -288,6 +288,7 @@ operators:
- integration-name: AWS Lambda
python-modules:
- airflow.providers.amazon.aws.operators.aws_lambda
Review Comment:
Hmm. I think we should fix the failing tests actually. I prefer to keep the
provider.yaml to describe "current" state not some mixture between new and old
state - we do not even track which entries are deprecated here.
BTW. Maybe there are other cases like that already but if they are, we
should fix it so that the tests do not fail here and right after we should add
tests finding similar deprecated entries and remove them. Happy to do it as a
follow-up actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
