vitaly-krugl commented on issue #25209: URL: https://github.com/apache/airflow/issues/25209#issuecomment-1190981965
One of the outcomes of this issue, besides fixing them and having adequate tests, is having guidelines in a migration/versions/README, or something like that, which discusses the unsafe practices to avoid. This would help maintainers and reviewers alike. On Wed, Jul 20, 2022, 8:55 PM Tzu-ping Chung ***@***.***> wrote: > Of the examples you provided, only migrations 23, 54 and 73 a problematic > (and you can see they are all fairly old). The rest are constants and > helper functions that are intended to be used in migrations and guaranteed > to not change. We should probably move them to somewhere else and add dev > documentation to make this clear, but using them is not a problem on itself. > > As for the actual problematic ones, feel free to fix them. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/issues/25209#issuecomment-1190916431>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAK72KSEPXX7QPJK23U22PLVVCNXJANCNFSM54FPL3FA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
