shashwatsrivastava94 commented on issue #25207: URL: https://github.com/apache/airflow/issues/25207#issuecomment-1191009142
That makes sense > We generally don’t want to allow the user to override behaviour in DAG because it’s executed directly in the Airflow process This reasoning makes sense - but if Im understanding this correctly, the callback functions also run in the Airflow process correct? I can see messing up this method being less common than overriding the methods but can you confirm that this would have the same affect. Want to make sure that Im following the code correctly. Can you also point me to where we re-create the `on_success_callback` method when deserializing a DAG from the metadata DB? I see this code https://github.com/apache/airflow/blob/cff7d9194f549d801947f47dfce4b5d6870bfaaa/airflow/serialization/serialized_objects.py#L1091 to add `has_on_success_callback` but I cant figure out where we deserialize or recreate the callback methods for `on_success/failure` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
