bdsoha commented on code in PR #25183:
URL: https://github.com/apache/airflow/pull/25183#discussion_r926316352
##########
airflow/providers/apache/livy/hooks/livy.py:
##########
@@ -75,10 +76,12 @@ def __init__(
livy_conn_id: str = default_conn_name,
extra_options: Optional[Dict[str, Any]] = None,
extra_headers: Optional[Dict[str, Any]] = None,
+ auth_type: Optional[Any] = None
) -> None:
super().__init__(http_conn_id=livy_conn_id)
self.extra_headers = extra_headers or {}
self.extra_options = extra_options or {}
+ self.auth_type = auth_type or self.auth_type
Review Comment:
The inherited `HttpHook` sets a default value to `self.auth_type` which
should be used when the argument `auth_type==None`.
It could have also been handled as such:
1. Using a *ternary statement*:
```python
self.auth_type = auth_type if auth_type else self.auth_type
```
2. Using an *if-conditional*:
```python
if auth_type:
self.auth_type = auth_type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
