potiuk commented on code in PR #25185:
URL: https://github.com/apache/airflow/pull/25185#discussion_r927104026


##########
airflow/providers/microsoft/mssql/hooks/mssql.py:
##########
@@ -51,6 +51,13 @@ def get_conn(
         )
         return conn
 
+    def get_uri(self) -> str:
+        from urllib.parse import urlsplit, urlunsplit
+
+        r = list(urlsplit(super().get_uri()))
+        r[0] = "mssql+pymssql"  # fix to use pymssql driver
+        return urlunsplit(r)

Review Comment:
   > By the way the docstring in odbc provider for sqlalchemy_scheme is copy 
pasted:
   
   Yep. Fixing it is a good idea - you can even do it in this PR or open 
another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to