uranusjr commented on code in PR #25268:
URL: https://github.com/apache/airflow/pull/25268#discussion_r928476262
##########
airflow/providers/mysql/hooks/mysql.py:
##########
@@ -61,6 +61,8 @@ def __init__(self, *args, **kwargs) -> None:
def set_autocommit(self, conn: MySQLConnectionTypes, autocommit: bool) ->
None:
"""
+ Mysqldb client uses an `autocommit` method rather than an `autocommit`
property.
+
The MySQLdb (mysqlclient) client uses an `autocommit` method rather
Review Comment:
MySQLdb is the old name (Python 2 branch) of mysqlclient, the Python library
to connect to MySQL. Since we don’t support Python 2 anymore, this should only
mention mysqlclient.
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -149,6 +149,8 @@ async def __aexit__(self, *err):
@staticmethod
def _parse_host(host: str) -> str:
"""
+ Robustness to improper connections settings provided by users.
Review Comment:
I have trouble understanding what this means.
##########
airflow/providers/google/cloud/hooks/cloud_memorystore.py:
##########
@@ -392,8 +394,7 @@ def list_instances(
metadata: Sequence[Tuple[str, str]] = (),
):
"""
- Lists all Redis instances owned by a project in either the specified
location (region) or all
- locations.
+ Lists all Redis instances owned by a project at the specified
location (region) or all locations.
Review Comment:
```suggestion
Lists all Redis instances owned by a project at the specified
location (region) or all locations.
```
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -175,21 +177,22 @@ def _parse_host(host: str) -> str:
def _get_retry_object(self) -> Retrying:
"""
- Instantiates a retry object
+ Instantiates a retry object.
:return: instance of Retrying class
"""
return Retrying(**self.retry_args)
def _a_get_retry_object(self) -> AsyncRetrying:
"""
- Instantiates an async retry object
+ Instantiates an async retry object.
:return: instance of AsyncRetrying class
"""
return AsyncRetrying(**self.retry_args)
def _get_aad_token(self, resource: str) -> str:
"""
- Function to get AAD token for given resource. Supports managed
identity or service principal auth
+ Function to get AAD token for given resource.
+ Supports managed identity or service principal auth
Review Comment:
```suggestion
Function to get AAD token for given resource.
Supports managed identity or service principal auth.
```
I think there’s also a rule that the first line must not go over a certain
length, and since reStructuredText has a line-collapsing rule, we need an empty
line to prevent these being merged into a line.
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -597,7 +601,9 @@ def _retryable_error(exception: BaseException) -> bool:
class _TokenAuth(AuthBase):
"""
- Helper class for requests Auth field. AuthBase requires you to implement
the __call__
+ Helper class for requests Auth field.
+
+ AuthBase requires you to implement the __call__
Review Comment:
```suggestion
AuthBase requires you to implement the ``__call__``
```
##########
airflow/providers/mysql/hooks/mysql.py:
##########
@@ -146,6 +150,8 @@ def _get_conn_config_mysql_connector_python(self, conn:
Connection) -> Dict:
def get_conn(self) -> MySQLConnectionTypes:
"""
+ Connection to a mysql database.
Review Comment:
```suggestion
Connection to a MySQL database.
```
##########
airflow/utils/process_utils.py:
##########
@@ -190,6 +192,8 @@ def execute_in_subprocess_with_kwargs(cmd: List[str],
**kwargs) -> None:
def execute_interactive(cmd: List[str], **kwargs) -> None:
"""
+ Runs the new command as a subproce.
Review Comment:
```suggestion
Runs the new command as a subprocess.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
