potiuk commented on code in PR #25299:
URL: https://github.com/apache/airflow/pull/25299#discussion_r929709365
##########
airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -981,15 +981,13 @@ def to_csv(
self.log.info("Done. Loaded a total of %s rows.", i)
- def get_records(
- self, hql: str, schema: str = 'default', hive_conf: Optional[Dict[Any,
Any]] = None
- ) -> Any:
+ def get_records(self, sql: Union[str, List[str]], parameters:
Optional[Any] = None, **kwargs) -> Any:
Review Comment:
Actually:
```
"get_records" incompatible with supertype "DbApiHook" [override]
def get_records(
^
airflow/providers/apache/hive/hooks/hive.py:984: note: Superclass:
airflow/providers/apache/hive/hooks/hive.py:984: note: def
get_records(self, sql: Union[str, List[str]], parameters: Optional[Any] = ...,
**kwargs: Dict[Any, Any]) -> Any
airflow/providers/apache/hive/hooks/hive.py:984: note: Subclass:
airflow/providers/apache/hive/hooks/hive.py:984: note: def
get_records(self, sql: Union[str, List[str]], parameters: Optional[Any] = ...,
*, schema: str = ..., **kwargs: Any) -> Any
```
I'd like to avoid overloads here so possibly the scheme kwars was a bit
better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
