Taragolis commented on PR #25248:
URL: https://github.com/apache/airflow/pull/25248#issuecomment-1195361223

   I found that Extra Links do not work with dynamic tasks at all.
   Extra links assign to parent task instance (i do not know how to correct 
name this TI) but not to actual mapped TIs.
   As result we only have `number extra links defined in operator` not `(number 
extra links defined in operator) x number of mapped TIs`
   
   ### Sample DAG
   
   ```python
   from pendulum import datetime
   
   from airflow.decorators import dag
   from airflow.sensors.external_task import ExternalTaskSensor
   from airflow.operators.empty import EmptyOperator
   
   EXTERNAL_DAG_IDS = [f"example_external_dag_{ix:02d}" for ix in range(3)]
   DAG_KWARGS = {
       "start_date": datetime(2022, 7, 1),
       "schedule_interval": "@daily",
       "catchup": False,
       "tags": ["mapped_extra_links", "AIP-42", "serialization"],
   }
   
   
   def external_dags():
       EmptyOperator(task_id="dummy")
   
   
   @dag(**DAG_KWARGS)
   def external_regular_task_sensor():
       for external_dag_id in EXTERNAL_DAG_IDS:
           ExternalTaskSensor(
               task_id=f'wait_for_{external_dag_id}',
               external_dag_id=external_dag_id,
               poke_interval=5,
           )
   
   
   @dag(**DAG_KWARGS)
   def external_mapped_task_sensor():
       ExternalTaskSensor.partial(
           task_id='wait',
           poke_interval=5,
       ).expand(external_dag_id=EXTERNAL_DAG_IDS)
   
   
   dag_external_regular_task_sensor = external_regular_task_sensor()
   dag_external_mapped_task_sensor = external_mapped_task_sensor()
   
   for dag_id in EXTERNAL_DAG_IDS:
       globals()[dag_id] = dag(dag_id=dag_id, **DAG_KWARGS)(external_dags)()
   
   ```
   
   <details>
     <summary>Video Demo</summary>
   
   
https://user-images.githubusercontent.com/3998685/180994213-847b3fd3-d351-4836-b246-b54056f34ad6.mp4
   
   </details>
   
   Might be better do not serialize Extra Links for dynamic tasks at all?
   WDYT @potiuk @uranusjr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to