uranusjr commented on PR #23662:
URL: https://github.com/apache/airflow/pull/23662#issuecomment-1196324285
Implementation looks good, but the class inheritance is a bit too
complicated now to me. Since CronTriggerTimetable doesn’t actually share a lot
of logic with DeltaDataIntervalTimetable, it’s probably better to make them
more separated. It should be possible to do inheritance like this instead:
```
┌─────────────┐
│
│
│
Timetable │
│
│
└──▲───────▲──┘
│ │
┌─────────────────────────────────────────┘ │
│ │
┌──────────┴───────────┐ ┌─────────────┐ │
│ │ │ │ │
│_DataIntervalTimetable│ │ _CronMixin │ │
│ │ │ │ │
└───▲───────────────▲──┘ └──▲──────▲───┘ │
│ │ │ │ │
│ │ │ └──────────┐ │
│ │ │ │ │
┌──────────────────┴───────┐ ┌─────┴───────────────┴─────┐
┌───────┴──────┴───────┐
│ │ │ │ │
│
│DeltaDataIntervalTimetable│ │ CronDataIntervalTimetable │ │
CronTriggerTimetable │
│ │ │ │ │
│
└──────────────────────────┘ └───────────────────────────┘
└──────────────────────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
