uranusjr commented on code in PR #23662:
URL: https://github.com/apache/airflow/pull/23662#discussion_r930771950
##########
airflow/timetables/interval.py:
##########
@@ -158,7 +158,7 @@ def __eq__(self, other: Any) -> bool:
This is only for testing purposes and should not be relied on
otherwise.
"""
- if not isinstance(other, CronDataIntervalTimetable):
+ if not isinstance(other, _CronMixin):
Review Comment:
This should be something like `isinstance(other, type(self)`, otherwise a
`CronDataIntervalTimetable` and a `CronTriggerTimetable` may compare to True,
which is not what we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
