Taragolis opened a new pull request, #25336:
URL: https://github.com/apache/airflow/pull/25336

   Follow up #25256
   
   Right now `region_name` and `config` (botocore.config.Config) could be set 
in different places with this precedence rules (high to low):
   * Hooks methods arguments
   * Hooks attribute
   * In connection
   
   With this PR I tried to do in one place (AwsConnectionWrapper) by:
   1. Allow specify init values for `botocore_config` and `region_name` and 
keep them in wrapper
   2. Allow create AwsConnectionWrapper from another AwsConnectionWrapper
   
   Also this PR might introduce some breaking changes, previously if `config` 
specified in Connection than it always overrides config which explicit set in 
Hook arguments
   
   
https://github.com/apache/airflow/blob/432977be0cd1e95f623fa5edda2a227798fa2939/airflow/providers/amazon/aws/hooks/base_aws.py#L399-L402
   
   
https://github.com/apache/airflow/blob/28db8c10b2422d99217658a039cc6dc45a38ff51/airflow/providers/amazon/aws/hooks/base_aws.py#L454-L460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to