ashb commented on code in PR #25244:
URL: https://github.com/apache/airflow/pull/25244#discussion_r932029048
##########
airflow/www/static/js/dag/details/Header.tsx:
##########
@@ -54,33 +53,21 @@ const Header = () => {
let runLabel;
if (dagRun && runId) {
- if (runId.includes('manual__') || runId.includes('scheduled__') ||
runId.includes('backfill__')) {
- runLabel = (<Time dateTime={dagRun.dataIntervalStart ||
dagRun.executionDate} />);
- } else {
- runLabel = runId;
- }
- if (dagRun.runType === 'manual') {
- runLabel = (
- <>
- <MdPlayArrow style={{ display: 'inline' }} />
- {runLabel}
- </>
- );
- } else if (dagRun.runType === 'backfill') {
- runLabel = (
- <>
- <RiArrowGoBackFill style={{ display: 'inline' }} />
- {runLabel}
- </>
- );
- } else if (dagRun.runType === 'scheduled') {
- runLabel = (
- <>
- <MdOutlineSchedule style={{ display: 'inline' }} />
- {runLabel}
- </>
- );
- }
+ // If a runId includes the runtype then parse the time, otherwise use the
custom run id
+ const runName = (
+ runId.includes('manual__')
+ || runId.includes('scheduled__')
+ || runId.includes('backfill__')
+ || runId.includes('dataset_triggered__')
Review Comment:
Good question. I guess this isn't really changing the behaviour here though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
