ashb commented on issue #5428: AIRFLOW-4809 | s3_delete_objects_operator should 
not fail on empty list of keys
URL: https://github.com/apache/airflow/pull/5428#issuecomment-503469319
 
 
   `not_found_mode` isn't quite right for the empty list case, unless it also 
controls the behaviour when trying to delete a non-existent object. (I don't 
know how that currently behaves)
   
   Force isn't quite right either - although that does stop `rm` complaining 
about non-existent files, it also makes it ignore read-only and delete anyway, 
which isn't something we'd do here.
   
   In short: names are hard, I don't know. It doesn't have to match the name of 
the flag from the imap hook, no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to