potiuk commented on issue #21496: URL: https://github.com/apache/airflow/issues/21496#issuecomment-1199059970
> We can update those docs to suggest using constraints ([like we already do when explaining how to install `apache-airflow` locally](https://airflow.apache.org/docs/apache-airflow/stable/start/local.html)), for example: Feel free :) > Also, might consider extending the _PIP_ADDITIONAL_REQUIREMENTS feature of the docker image with something similar to airflow.protectedPipPackages from the [Airflow Helm Chart (User Community)](https://github.com/airflow-helm/charts/tree/main/charts/airflow), which causes dynamic pip-installs to fail if they would upgrade/downgrade the pre-installed apache-airflow version. Nope. This is a cery bad practice and users should not do it in production. We discussed it many times, and we are NOT going to make our users install packages in production - the only proper way of adding extra packages is to build your own image if you use Helm. Nothing changed since the last time we disussed it. `_PIP_ADDITIONAL_REQUIREMENTS` is deliberately development-only feature and we are not going to make it 'safer'. Actually, this is a FEATURE of that development-only variable to make it unsafe and be careful. If someone (ignoring many warnings, including one written in the logs when they use it) will be burned this is the best way for the users to learn not to use it in production. If we make it 'safer' to use, this totally undermine our vision of steering the users towards learning how to build their images. The thing is, your proposal are turning the dynamic installation into a feature, and we deliberatly want to make it "non-feature". Our goal is not to make it "safer" to use it, but for people to "stop" using it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
