marlock9 commented on PR #24153:
URL: https://github.com/apache/airflow/pull/24153#issuecomment-1199966788

   @potiuk IMHO, the main problem is that this exact pull request have deleted 
using of `log_filename_template` and now it shows warning about deprecation of 
using it: 
https://github.com/apache/airflow/pull/24153/files#diff-e7f34f73940eb52d92bb991abedc1c963431c5373c12dff739c8fb7d03e93d3aR53
   But this property was not removed from 
`airflow/config_templates/default_airflow.cfg` from which the default config 
generates on first run of airflow, it was removed only from 
`airflow/config_templates/airflow_local_settings.py` and 
`airflow/config_templates/default_test.cfg`.
   So now, even when having this parameter deleted from environment variables 
this parameter is passed to airflow from that generated config. Setting value 
to empty string in env vars is also not helpful, because the check is for None 
type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to