Taragolis commented on PR #25416: URL: https://github.com/apache/airflow/pull/25416#issuecomment-1203706947
@gmcrocetti regarding to #25494 Again, my personal thought, I still would suggest to hide `host` because it never (at least since Airflow 1.9) use in AwsHook. And might be better replace `extra['host']` by `extra['endpoint_url']` for maintain uniformity with `boto3.client` and `boto3.resource`. Couple month ago I've also played with extra fields in UI, by same way as it implemented in SnowflakeHook  https://github.com/apache/airflow/blob/298be502c35006b7c3f011b676dbb4db0633bc74/airflow/providers/snowflake/hooks/snowflake.py#L85-L109 However I stoped by couple reasons: 1. AwsHook at that moment had a lot of ways to did the same things. 2. All custom fields stored in `Connection['extra']` as `extra__{conn_type}__{field_name}` in this case we need also care about some funny cases such as: ```python Connection( conn_id="aws_conn_hell", conn_type="aws", extra={ "region_name": "us-east-1", "extra__aws__region_name": "eu-west-1", "session_kwargs": { "region_name": "cn-north-1", } } ) ``` 3. Right now BaseSessionFactory supports custom SAML auth and WebIdentity by Google and both of them also have their own attributes in `Connection['extra']` So I would suggest to make `AwsHook` and `BaseSessionFactory` use only generic fields in Connection, make easier way to add custom federation Auth and only after that we may add additional fields in the UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
