Aakcht commented on code in PR #25283:
URL: https://github.com/apache/airflow/pull/25283#discussion_r936508551
##########
chart/values.schema.json:
##########
@@ -857,6 +857,15 @@
"description": "Type **as string** of secret E.G.
Opaque, kubernetes.io/dockerconfigjson, etc.",
"type": "string"
},
+ "labels": {
+ "description": "Labels for the secret",
+ "type": "object",
+ "additionalProperties": {
+ "description": "Label key",
Review Comment:
@jedcunningham probably not, but I am getting the following error in static
checks when I try to remove `description` or `default` from here:
```
Processing file: chart/values.schema.json
'description' is a required property
Failed validating 'required' in
schema['properties']['properties']['additionalProperties']['allOf'][0]['additionalProperties']['additionalProperties']['additionalProperties']['additionalProperties']['then']:
{'required': ['description', 'default']}
On
instance['properties']['extraConfigMaps']['additionalProperties']['properties']['labels']['additionalProperties']:
{'type': 'string'}
'default' is a required property
Failed validating 'required' in
schema['properties']['properties']['additionalProperties']['allOf'][0]['additionalProperties']['additionalProperties']['additionalProperties']['additionalProperties']['then']:
{'required': ['description', 'default']}
On
instance['properties']['extraConfigMaps']['additionalProperties']['properties']['labels']['additionalProperties']:
{'type': 'string'}
```
Looks like one possible way to fix it is to remove the lines 7-11 from
https://github.com/apache/airflow/blob/main/chart/values_schema.schema.json :
```
"additionalProperties": {
"additionalProperties": {
"$ref": "#/definitions/leafs"
}
},
```
Should I just remove these lines? Or should I leave it as it is? Or maybe
there are better ways to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
