ashb commented on code in PR #25161:
URL: https://github.com/apache/airflow/pull/25161#discussion_r937580391
##########
airflow/executors/base_executor.py:
##########
@@ -332,10 +332,26 @@ def slots_available(self):
return sys.maxsize
@staticmethod
- def validate_command(command: List[str]) -> None:
- """Check if the command to execute is airflow command"""
+ def validate_airflow_tasks_run_command(command: List[str]) ->
Tuple[Optional[str], Optional[str]]:
Review Comment:
Oh. This counts as a breaking change if anyone has written a custom executor
and was calling `validate_command` (which they should be ideally) it would now
blow up.
Given that maybe two separate functions might be the way to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
