jhtimmins commented on code in PR #25528:
URL: https://github.com/apache/airflow/pull/25528#discussion_r938399729


##########
airflow/config_templates/airflow_local_settings.py:
##########
@@ -48,6 +49,8 @@
 
 COLORED_FORMATTER_CLASS: str = conf.get_mandatory_value('logging', 
'COLORED_FORMATTER_CLASS')
 
+DAG_PROCESSOR_LOG_TARGET: bool = conf.get_mandatory_value('scheduler', 
'DAG_PROCESSOR_LOG_TARGET')

Review Comment:
   Yeah I'm uncertain of the convention here. It seems like `logging` makes 
more sense, however, when the logs are sent to files, the proper directory is 
defined under `scheduler.child_process_log_directory`. That's why I put it in 
scheduler.
   
   With that in mind, which do you think makes more sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to