FanatoniQ commented on PR #25412:
URL: https://github.com/apache/airflow/pull/25412#issuecomment-1207365681

   > Yep. I think it's not technically needed now - the effect is the same, 
though the difference is that it allows to override the handler in JDBC, which 
might be a useful thing.
   
   Ok I agree.
   
   Quick question: shouldn't this handler parameter, and sql operator run 
methods return value feature used alongside `do_xcom_push` be coded in a common 
parent SQL class ? I found the other day that `MsSqlOperator` and 
`MySqlOperator` run methods do not return the result...
   
   Is that planned ? I am asking after seeing this commit's message: "move all 
old sql operator...":  
https://github.com/apache/airflow/commit/acab8f52dd8d90fd6583779127895dd343780f79


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to