potiuk commented on code in PR #25494:
URL: https://github.com/apache/airflow/pull/25494#discussion_r940197227
##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -154,6 +154,16 @@ def __post_init__(self, conn: "Connection"):
self.endpoint_url = extra.get("host")
+ if self.endpoint_url:
+ warnings.warn(
+ "extra['host'] is deprecated and will be removed in a future
release."
Review Comment:
Yeah. That's a bit aggressive, but we could raise plain error here. I do
not see this as being a major problem. But removing it altogether is not a good
idea because it would likely stop doing that it was doing before without even a
warning in some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
