uranusjr commented on code in PR #25410:
URL: https://github.com/apache/airflow/pull/25410#discussion_r940953646
##########
docs/apache-airflow/dag-run.rst:
##########
@@ -102,7 +101,7 @@ scheduled one interval after ``start_date``.
.. tip::
- If ``schedule_interval`` is not enough to express your DAG's schedule,
+ If a cron expression or `timedelta` object is not enough to express your
DAG's schedule,
Review Comment:
```suggestion
If a cron expression or timedelta object is not enough to express your
DAG's schedule,
```
##########
docs/apache-airflow/faq.rst:
##########
@@ -376,7 +376,7 @@ Why ``next_ds`` or ``prev_ds`` might not contain expected
values?
------------------------------------------------------------------
- When scheduling DAG, the ``next_ds`` ``next_ds_nodash`` ``prev_ds``
``prev_ds_nodash`` are calculated using
- ``execution_date`` and ``schedule_interval``. If you set
``schedule_interval`` as ``None`` or ``@once``,
+ ``logical_date`` and the DAG's schedule interval (if applicable). If you set
``schedule`` as ``None`` or ``@once``,
Review Comment:
```suggestion
``logical_date`` and the DAG's schedule (if applicable). If you set
``schedule`` as ``None`` or ``@once``,
```
##########
docs/apache-airflow/faq.rst:
##########
@@ -224,15 +224,15 @@ an hour after now as ``now()`` moves along.
Previously, we also recommended using rounded ``start_date`` in relation to
your
-``schedule_interval``. This meant an ``@hourly`` would be at ``00:00``
+DAG ``schedule``. This meant an ``@hourly`` would be at ``00:00``
Review Comment:
```suggestion
DAG's ``schedule``. This meant an ``@hourly`` would be at ``00:00``
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
