ashb commented on code in PR #25094:
URL: https://github.com/apache/airflow/pull/25094#discussion_r942879873
##########
airflow/models/dagbag.py:
##########
@@ -337,14 +336,14 @@ def parse(mod_name, filepath):
if dagbag_import_timeout <= 0: # no parsing timeout
return parse(mod_name, filepath)
- timeout_msg = (
+ timeout_msg = ( # noqa
f"DagBag import timeout for {filepath} after
{dagbag_import_timeout}s.\n"
"Please take a look at these docs to improve your DAG import
time:\n"
f"* {get_docs_url('best-practices.html#top-level-python-code')}\n"
f"* {get_docs_url('best-practices.html#reducing-dag-complexity')}"
)
- with timeout(dagbag_import_timeout, error_message=timeout_msg):
- return parse(mod_name, filepath)
+ # with timeout(dagbag_import_timeout, error_message=timeout_msg):
Review Comment:
This method (load a dag from a file) should never be used remotely anyway,
should it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
