pabloem commented on code in PR #24980:
URL: https://github.com/apache/airflow/pull/24980#discussion_r943747674
##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -124,7 +124,10 @@ class DataflowConfiguration:
WaitForRun = wait until job finished and the run job.
Supported only by:
:py:class:`~airflow.providers.apache.beam.operators.beam.BeamRunJavaPipelineOperator`
- :param service_account: Run the job as a specific service account, instead
of the default GCE robot.
+ :param service_account: Run the Java job as a specific service account,
instead of the default Compute Engine service account.
+ See:
https://cloud.google.com/dataflow/docs/reference/pipeline-options#java
+ :param service_account_email: Run the Python or Go job as a specific
service account for Python or Go, instead of the default Compute Engine service
account.
+ See:
https://cloud.google.com/dataflow/docs/reference/pipeline-options#python or
https://cloud.google.com/dataflow/docs/reference/pipeline-options#go
Review Comment:
I just wonder if it doesn't make sense to put these into a single parameter
rather than two separate ones? The documentation is quite clear, so it may not
be a big deal - but ideally users only have to care about one parameter?
I understand that complicates the logic downstream, but maybe it's better to
complicate downstream than enable users to misconfigure/be confused?
also, sorry about the delay ^^'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
