uranusjr commented on code in PR #25675:
URL: https://github.com/apache/airflow/pull/25675#discussion_r944095967
##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -128,31 +128,45 @@ def get_media_request(self, file_id: str) -> HttpRequest:
request = service.files().get_media(fileId=file_id)
return request
- def exists(self, folder_id: str, file_name: str, drive_id: Optional[str] =
None):
+ def exists(
+ self, folder_id: str, file_name: str, include_trashed: bool = True,
drive_id: Optional[str] = None
Review Comment:
Can we change the ordering to put `include_trashed` at the back? Right now
this (unnecessarily) breaks backward compatibility if the user passes
`drive_id` as a positional argument.
Maybe it’s best to make the new argument keyword-only as well, so future
additions don’t break compatibility easily:
```python
def exists(
self,
folder_id: str,
file_name: str,
drive_id: Optional[str] = None,
*,
include_trashed: bool = True,
) -> bool:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
