wolfier opened a new pull request, #25715:
URL: https://github.com/apache/airflow/pull/25715

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #25493
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   closes: #25493
   
   When filtering DAGs based on tags and there are no matching DAGs, the UI 
will not display any DAGs as expected. The confusing part is that the tags 
filter box will not have any entries in there either. This is what confuses the 
users where they think there are no filters but there are also no DAGs.
   
   Since the tags filter box won't allow for tags not used by DAGs, it made 
more sense to redirect the URL and wipe the tags when there are no valid tags 
in the query parameters.
   
   When there are valid tags and invalid tags, there will be no redirects since 
the valid tags do still show up on the UI indicating to the user that there are 
filtering happening.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to