This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 762588dcf4 fix bug construction of Connection object in version
5.0.0rc3 (#25716)
762588dcf4 is described below
commit 762588dcf4a05c47aa253b864bda00726a5569dc
Author: Daniel Reeves <[email protected]>
AuthorDate: Mon Aug 15 06:14:39 2022 -0400
fix bug construction of Connection object in version 5.0.0rc3 (#25716)
---
airflow/providers/amazon/aws/secrets/secrets_manager.py | 1 +
tests/providers/amazon/aws/secrets/test_secrets_manager.py | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/airflow/providers/amazon/aws/secrets/secrets_manager.py
b/airflow/providers/amazon/aws/secrets/secrets_manager.py
index faf9c9ae05..e0d05a5ae4 100644
--- a/airflow/providers/amazon/aws/secrets/secrets_manager.py
+++ b/airflow/providers/amazon/aws/secrets/secrets_manager.py
@@ -197,6 +197,7 @@ class SecretsManagerBackend(BaseSecretsBackend,
LoggingMixin):
port = int(data['port'])
return Connection(
+ conn_id=conn_id,
login=data['user'],
password=data['password'],
host=data['host'],
diff --git a/tests/providers/amazon/aws/secrets/test_secrets_manager.py
b/tests/providers/amazon/aws/secrets/test_secrets_manager.py
index 13c785caec..30c0053776 100644
--- a/tests/providers/amazon/aws/secrets/test_secrets_manager.py
+++ b/tests/providers/amazon/aws/secrets/test_secrets_manager.py
@@ -77,6 +77,7 @@ class TestSecretsManagerBackend(TestCase):
assert conn.login == 'is url encoded'
assert conn.password == 'not url encoded'
assert conn.host == 'not%20idempotent'
+ assert conn.conn_id == 'test_postgres'
# Remove URL encoding
secrets_manager_backend.are_secret_values_urlencoded = False
@@ -85,7 +86,7 @@ class TestSecretsManagerBackend(TestCase):
assert conn.login == 'is%20url%20encoded'
assert conn.password == 'not url encoded'
assert conn.host == 'not%2520idempotent'
-
+ assert conn.conn_id == 'test_postgres'
assert conn.extra_dejson['foo'] == 'bar'
@mock_secretsmanager
