potiuk commented on PR #20659:
URL: https://github.com/apache/airflow/pull/20659#issuecomment-1215138496

   > @ashb I highly appreciate everyone's time and effort, but what's wrong 
with calling mistake a mistake? The "huge" correlates with the fact that @kaxil 
directly asked (which is a fantastic call) whether this will break the clearing 
functionality and the answer was "no, it won't".
   
   @dmishh - let me explain what I think @ashb had in mind (or at least how I 
feel it as it is close to what I feel when I read your comment).  The way you 
expressed it, looked like the whole change was a huge mistake. I believe (also 
knowing Ash) he did not complain on naming things a mistake but about your way 
of communicating and asking for it.
   
   For example If you had started your first comment with "I highly appreciate 
everyone's time and effort and I see how much this PR improved, but it also 
mistakenly removed this and that" - that would be much nicer way to say what 
you possibly wanted to say (looking at your secondd comment you do appreiciate 
the work but it was not seen from the first comment. 
   It's very difficult to express the feelings in a written form when you write 
a comment in PR and I think learning it is an art.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to