Taragolis commented on PR #24153:
URL: https://github.com/apache/airflow/pull/24153#issuecomment-1216834220

   @uranusjr  Seems like all of this remote task handlers inherited from 
`FileTaskHandler`
   - `airflow.providers.amazon.aws.log.s3_task_handler.S3TaskHandler`
   -  
`airflow.providers.amazon.aws.log.cloudwatch_task_handler.CloudwatchTaskHandler`
   - `airflow.providers.google.cloud.log.gcs_task_handler.GCSTaskHandler`
   - `airflow.providers.microsoft.azure.log.wasb_task_handler.WasbTaskHandler`
   - `airflow.providers.alibaba.cloud.log.oss_task_handler.OSSTaskHandler`
   - 
`airflow.providers.elasticsearch.log.es_task_handler.ElasticsearchTaskHandler`
   
   All of them pass `[logging] log_filename_template` value to class args 
`filename_template ` but do not use this attribute directly in handler (latest 
version of providers)
   
   S3 handler
   ---
   
   
https://github.com/apache/airflow/blob/90338398a67cf8d8ffc6ed0418126d2d76002eb9/airflow/config_templates/airflow_local_settings.py#L58-L60
   
   Init
   
https://github.com/apache/airflow/blob/90338398a67cf8d8ffc6ed0418126d2d76002eb9/airflow/config_templates/airflow_local_settings.py#L193-L201
   
   Pass to `FileTaskHandler`
   
https://github.com/apache/airflow/blob/90338398a67cf8d8ffc6ed0418126d2d76002eb9/airflow/providers/amazon/aws/log/s3_task_handler.py#L28-L36
   
   Remove this parameter from initialise this handler remove this warning, 
however I do not check all previous version of providers and is it possible 
that previously it uses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to