potiuk commented on code in PR #25780:
URL: https://github.com/apache/airflow/pull/25780#discussion_r948847654
##########
airflow/operators/python.py:
##########
@@ -176,7 +178,7 @@ def execute(self, context: Context) -> Any:
return return_value
- def determine_kwargs(self, context: Mapping[str, Any]) -> Mapping[str,
Any]:
+ def determine_kwargs(self, context: MutableMapping[str, Any]) ->
MutableMapping[str, Any]:
Review Comment:
I think I know why MyPy was complaining. The problem was that if only .py
file changed, Mypy did not really use .pyi file to determine the actual type -
we have a number of cases where type in .pyi overrides the types and if it does
not change and MyPy does not see the .pyi file it will not know the type is
overridden in .pyi file when you run it incrementally.
I will add a small change to the mypy pre-commit to see if there are .pyi
files corresponding to changed .py files and add them to the list of files if
they are missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
