jbmeerkat commented on code in PR #25802: URL: https://github.com/apache/airflow/pull/25802#discussion_r949577374
########## RELEASE_NOTES.rst: ########## @@ -502,6 +502,12 @@ Airflow 2.3.0 restores the original meaning to the parameter. If you set it to " can be embedded in an iframe (no header is added), but when you set it to "false" the header is added and Airflow cannot be embedded in an iframe. +``MySQLToS3Operator`` argument `pd_csv_kwargs` has beed replaced with `pd_kwargs` (#20807) +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Although the old one (``pd_csv_kwargs``) is still accepted but no longer taken into account. Considering +``MySQLToS3Operator`` deprecation it is recommeded to switch to ``SqlToS3Operator``. Doing this keep in mind +that ``index`` and ``header`` arguments should be moved into ``pd_kwargs`` dict. Review Comment: Thank you for the quick response Elad! I think it's important to list it here because this change can silently break data. In my case it happened—my custom line separator and column separator were ignored, because `pd_csv_kwargs` is not longer in use, and a lot of data became unusable which resulted in large amount of work. Honestly speaking I'd consider it a bug. If it's a deprecation nothing should be broken but in this case it was. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
