uranusjr commented on code in PR #25795:
URL: https://github.com/apache/airflow/pull/25795#discussion_r950002607


##########
airflow/api/common/trigger_dag.py:
##########
@@ -68,7 +68,9 @@ def _trigger_dag(
                 f"[{min_dag_start_date.isoformat()}] from DAG's default_args"
             )
 
-    run_id = run_id or DagRun.generate_run_id(DagRunType.MANUAL, 
execution_date)
+    run_id = run_id or dag.timetable.generate_run_id(
+        run_type=DagRunType.MANUAL, logical_date=execution_date, 
data_interval=None

Review Comment:
   We always need a data interval anyway, so the `data_interval=None` case can 
be avoided by moving the data interval logic before this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to