potiuk commented on PR #25785: URL: https://github.com/apache/airflow/pull/25785#issuecomment-1221051817
> @uranusjr @kaxil I don't think this is a breaking change for users. We have fixed all references of this **private** function. No one should ever use the private function from outside the provider. We should not guarantee private interface compatibility in my opinion. Otherwise we would have to do it for every private function we change. I think @kaxil is right. Technically speaking `_get_credentials()` is actually a `protected` method not `private` one. Private methods start with double underscores `__` . And GoogleBaseHook is almost by definition a Base classs for multiple Hooks so if someone created `TheyOwnGoogleBaseHook`, using `_get_credentials()` is not only allowed, but actually very likely. I do believe we need back-compat `_get_credentials()` as @kaxil suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
