uranusjr commented on code in PR #25943:
URL: https://github.com/apache/airflow/pull/25943#discussion_r954042943
##########
airflow/models/taskinstance.py:
##########
@@ -584,8 +584,12 @@ def __init__(
# can be changed when calling 'run'
self.test_mode = False
- self.dataset_event_manager = conf.getimport(
- 'core', 'dataset_event_manager_class',
fallback='airflow.datasets.manager.DatasetEventManager'
+ @cached_property
+ def dataset_event_manager(self):
+ return conf.getimport(
+ section='core',
+ key='dataset_event_manager_class',
+ fallback='airflow.datasets.manager.DatasetEventManager',
)()
Review Comment:
Why does this need to be an instance-wide property in the first place? Do we
plan to add hook so each task instance can have a different manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
