uranusjr commented on code in PR #25939:
URL: https://github.com/apache/airflow/pull/25939#discussion_r954666011
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -348,7 +348,7 @@ def get_cursor(self):
return self.get_conn().cursor()
@staticmethod
- def _generate_insert_sql(table, values, target_fields, replace, **kwargs):
+ def _generate_insert_sql(table, values, target_fields, replace,
placeholder="%s", **kwargs):
Review Comment:
Perhaps this should be a class attribute instead? It’s hard to imagine a SQL
backend would need to support multiple placeholder types, and we will probably
need to do the same for e.g. `UPDATE` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
