jedcunningham commented on code in PR #26089:
URL: https://github.com/apache/airflow/pull/26089#discussion_r959846034
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -3000,6 +3000,26 @@ def
test_send_sla_callbacks_to_processor_sla_with_task_slas(self, dag_maker):
expected_callback = SlaCallbackRequest(full_filepath=dag.fileloc,
dag_id=dag.dag_id)
self.scheduler_job.executor.callback_sink.send.assert_called_once_with(expected_callback)
+ @pytest.mark.parametrize(
+ "schedule",
+ [
+ None,
+ [Dataset("foo")],
Review Comment:
It does exist
[here](https://github.com/apache/airflow/blob/3a7e89dbddf5fc60dbcb9582acf5e3a79d702c7c/tests/jobs/test_scheduler_job.py#L2988),
but I should probably expand it to cover more cases. I'll do that in a bit
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
