potiuk opened a new pull request, #26091: URL: https://github.com/apache/airflow/pull/26091
The KPO tests were occasionally failing in CI because of race condition between delete from previous test and running the following tests. Simply speaking the pods run via KPO well not immediately sometimes and the following test picked them together with the current pod and failed becasue of duplicate pods. There was even a tearDown Delay of 1 second introduced as workaround to combat this problem. This PR fixes it much better. Each POD in the KPO test gets unique label (derived from test name) and when executing the POD this label is then used as selector, so that only the **just started** POD in current test are selected - not any dangling pod (being deleted) from the previous tests. This not only removes flakiness of the tests, but also remove the need of sleep, which speeds up the whole suite by whoooping 33 seconds (there were 33 tests to run). <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
