potiuk commented on PR #26151: URL: https://github.com/apache/airflow/pull/26151#issuecomment-1236312849
This is a bit of cleanup in the documentation of CI - introducing a "canary" name for our "main" workflow (which is basically what it is) and removing a number of variables that became unused by the recent changes of Breeze from bash to Python. cc: @mik-laj -> since we had recently discussions about that, this change also makes the docs a bit clearer and give more guidance for anyone who wants to use breeze in their own workflow, making sure that they do not use GITHUB_* variables to override the variables coming from GA (as you cannot change them) And also @o-nikolas -> since you wanted to understand more about the CI. I think this one describes more "whys" - changing the "main" build to be named "canary" and describing that PR runs are running in more "stable" environment. I think when you realise that this is the main purpose for having this comples CI with multiple run types makes it clearer why we have such setup. There will be few more cleanups after we complete the last step of Breeze conversion. We will be able to remove few more variables, and remove some remnants in the docs, but even now CI.rst is becoming more of a "WHY" description rather than "WHAT" description - it gets shorter and hopefully gives a chance to a passer-by to understand why we have all of the complexity. But if there are any suggestions on how we can improve those docs and describe it better, nicer, more concisely, maybe split it into separate documents, I am all ears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
