ashb commented on a change in pull request #5319:
[AIRFLOW-4564][AIRFLOW-4523][AIRFLOW-4577] Azure Container Instance bugfixes
and improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r296487570
##########
File path: airflow/contrib/hooks/azure_container_instance_hook.py
##########
@@ -92,43 +92,20 @@ def create_or_update(self, resource_group, name,
container_group):
name,
container_group)
- def get_state_exitcode_details(self, resource_group, name):
Review comment:
Removing this function is a breaking change - whilst the existing operators
are _likely_ the only thing callingit would it be possible to add a back-compat
shim:
```python
from zope.deprecated import deprecated
@deprecated
def get_state_exitcode_details(self, resource_group, name):
c_state = self.get_state(resource_group, name)
return (c_state.state, c_state.exit_code, c_state.detail_status)
```
(I think. Untested)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
