[GitHub] [airflow] uranusjr commented on a diff in pull request #26114: Make `execution_date_or_run_id` optional in `tasks test` command

Tue, 06 Sep 2022 22:25:10 -0700 


uranusjr commented on code in PR #26114:
URL: https://github.com/apache/airflow/pull/26114#discussion_r964393680


##########
airflow/cli/commands/task_command.py:
##########
@@ -75,9 +75,9 @@ def _generate_temporary_run_id() -> str:
 def _get_dag_run(
     *,
     dag: DAG,
-    exec_date_or_run_id: str,
     create_if_necessary: CreateIfNecessary,
-    session: Session,
+    exec_date_or_run_id: Optional[str] = None,
+    session: Session = NEW_SESSION,

Review Comment:
   You can keep it last, keyword-only means _you don’t need to add a default_ 
to keep it last.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to