potiuk commented on PR #26217: URL: https://github.com/apache/airflow/pull/26217#issuecomment-1239739063
@ashb - your points addressed. Good calls with them! There were a few more difficulties with the `.dot" images - because they were generated SLIGHTLY indeterministicly run-to-run - some tables were in random order (seems like one of the queries to get tables by the tool is not deterministicly sorted) - so i had to add a generated SHA256 of "migrations" directory to additionally verify if we need to run image generation (we do not run it again when the migrations dir did not change). this will also help to keep `pre-commit run --all-files` in our CI from failing (otherwise it would randomly fail). @jedcunningham @eladkal I also attempted to add warnings to both "ERD" and "Migrations" page to clearly explain the intent of those pages and what the users should expect from them. For me that was a bit unclear why we at all created the "migrations ref" page - at least it was not explained in the page why we published it, so I attempted to describe it in the way I understand why we did it. Also @rossturk - maybe you want to have a say here - WDYT about those descriptions and exposing ERD schema this way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
