potiuk commented on PR #24472:
URL: https://github.com/apache/airflow/pull/24472#issuecomment-1240486869

   > This bug was spotted by our automated tool statically. I am not familiar 
with the codebase so it would be difficult for me to add a test.
   
   Interesting, but I think without the automated false-positive detection and 
lack of reasoning leading to why it should be fixed it might be more noise than 
help. 
   
   Suggestion for furrher research in this area: Would be great if the tool 
also produced a likely "test" that tests the behaviour (and fails befiore and 
succeeds after). That would be a fantastic tool, as having tests whike 
reviewing is usually more productive than the code. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to