uranusjr commented on code in PR #26285:
URL: https://github.com/apache/airflow/pull/26285#discussion_r968155406
##########
airflow/providers/google/cloud/transfers/gcs_to_bigquery.py:
##########
@@ -315,16 +315,16 @@ def execute(self, context: 'Context'):
warnings.simplefilter("ignore", DeprecationWarning)
job_id = bq_hook.run_query(
sql=select_command,
+ location=self.location,
use_legacy_sql=False,
)
- row = list(bq_hook.get_job(job_id).result())
+ row = list(bq_hook.get_job(job_id=job_id,
location=self.location).result())
if row:
max_id = row[0] if row[0] else 0
self.log.info(
- 'Loaded BQ data with max %s.%s=%s',
- self.destination_project_dataset_table,
- self.max_id_key,
- max_id,
+ f'Loaded BQ data with max '
+
f'{self.destination_project_dataset_table}.{self.max_id_key}={max_id}',
)
Review Comment:
Log messages should not use f-string. Please revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
