jedcunningham commented on code in PR #26249:
URL: https://github.com/apache/airflow/pull/26249#discussion_r970269238
##########
airflow/models/taskinstance.py:
##########
@@ -509,14 +509,8 @@ class TaskInstance(Base, LoggingMixin):
viewonly=True,
)
- trigger = relationship(
- "Trigger",
- primaryjoin="TaskInstance.trigger_id == Trigger.id",
- foreign_keys=trigger_id,
- uselist=False,
- innerjoin=True,
- )
-
+ trigger = relationship("Trigger", uselist=False)
Review Comment:
Why don't we need innerjoin any longer?
##########
airflow/example_dags/example_time_delta_sensor_async.py:
##########
@@ -36,6 +36,6 @@
catchup=False,
tags=["example"],
) as dag:
- wait = TimeDeltaSensorAsync(task_id="wait",
delta=datetime.timedelta(seconds=10))
+ wait = TimeDeltaSensorAsync(task_id="wait",
delta=datetime.timedelta(seconds=120))
Review Comment:
```suggestion
wait = TimeDeltaSensorAsync(task_id="wait",
delta=datetime.timedelta(seconds=10))
```
Pretty big jump in runtime for an example dag... Maybe leave it as it was,
or a more modest increase instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
