potiuk commented on code in PR #26384:
URL: https://github.com/apache/airflow/pull/26384#discussion_r971116737
##########
airflow/models/baseoperator.py:
##########
@@ -1738,11 +1738,19 @@ def cross_downstream(
task.set_downstream(to_tasks)
+# pyupgrade assumes all type annotations can be lazily evaluated, but this is
+# not the case for attrs-decorated classes, since cattrs needs to evaluate the
+# annotation expressions at runtime, and Python before 3.9.0 does not lazily
+# evaluate those. Putting the expression in a top-level assignment statement
+# communicates this runtime requirement to pyupgrade.
+BaseOperatorClassList = List[Type[BaseOperator]]
Review Comment:
Indeed. That is even cooler :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
